Fix #1643: Null checks for card deletion and empty card arrays#2313
Open
kellyelton wants to merge 1 commit intomasterfrom
Open
Fix #1643: Null checks for card deletion and empty card arrays#2313kellyelton wants to merge 1 commit intomasterfrom
kellyelton wants to merge 1 commit intomasterfrom
Conversation
…eCard - Add null check for card.Group in DeleteCard to prevent NullReferenceException - Add empty array check in MoveCard to prevent IndexOutOfRangeException when all cards fail to resolve
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1643 - NullPointer during removal of a card
Two crash fixes:
NullReferenceException in DeleteCard: When a card is deleted and its Group is already null, the code would crash trying to call
card.Group.Remove(card). Added a null check.IndexOutOfRangeException in MoveCard: When all cards in a move request fail to resolve via
Card.Find(), the empty array was passed toMoveCardsconstructor which accessescards[0].Group. Added an empty array guard.Both fixes are defensive null/empty checks that prevent crashes during networked play.