Fix #1829: Allow card.moveTo(table) without controller check, fix error message#2314
Open
kellyelton wants to merge 1 commit intomasterfrom
Open
Fix #1829: Allow card.moveTo(table) without controller check, fix error message#2314kellyelton wants to merge 1 commit intomasterfrom
kellyelton wants to merge 1 commit intomasterfrom
Conversation
…or message - Skip group controller check when target is the table (shared group) - Fix error message that incorrectly referenced card name instead of group name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1829
Two fixes in CardMoveTo scripting API:
Allow moving cards to the table: The table is a shared group with no controller, so the controller check was incorrectly blocking moves to it. Added
!(group is Table)exception.Fix error message: The warning message said "they don't control {1}" when it should have said "{2}" (referencing the group name, not the card name).