ENH: Allow setting the container class #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just a first pass - I imagine there may be concern with too many kwargs on the instance eventually, so may instead want to put this in |
|
@grahamhoyes I'm very sorry I missed this, it looks good. I'd agree about your concern of too many kwargs on the instance but as we're a way from that we can think about that in version 1; I think this is fine. |
|
Tests aren't running because of an unrelated issue with django debug toolbar (which probably doesn't even need to be installed TBH, I'll clear that up in another branch/release). |
|
Thanks for your contribution @grahamhoyes :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #30 by adding an optional
wrapper_classkwarg to the widget. Defaults tosvelte-jsoneditor-wrapperfor backwards compatibility, but can be set to eg tailwind classes if using django-unfold.