Open
Conversation
Currently, 'humanize' is not explicitely set when creating a new chart. The default value `true` is later assigned as a fallback in the Chart class. I'd like to simplify those classes.
`data` was typed as `any`. This is not a good thing in itself. Moreover, it was only the values without the format. Also typeof is extremely permissive
The format of chart axis no longer depends on ranges, but now on the chart data.
This getter is only used once and the formatted values can be taken from the evaluated cells without the need to iterate over the entire range again.
The goal is ultimately to get the format from there instead of using the label range and reading again the cells (see next commit)
Extract chart data from ranges is now decoupled from everything else
Collaborator
|
|
LucasLefevre
force-pushed
the
master-chart-extract-data-4-lul
branch
from
219a4db to
4bcf288
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
description of this task, what is implemented and why it is implemented that way.
Task: TASK_ID
review checklist