[FIX] Style: UPDATE_CELL overwrites the cell style #7692
Closed
+41
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
|
hokolomopo
reviewed
Jan 6, 2026
tests/__mocks__/transport_service.ts
Outdated
| this.pendingMessages.push(message); | ||
| } else { | ||
| this.notifyListeners(message); | ||
| this.notifyListeners(JSON.parse(JSON.stringify(message))); |
Contributor
There was a problem hiding this comment.
nitpick: maybe a comment explaining why we do that, and not a deepCopy
rrahir
force-pushed
the
saas-19.1-fix-update-cell-style-change-rar
branch
2 times, most recently
from
6121cde to
de4d63e
Compare
LucasLefevre
reviewed
Jan 9, 2026
Collaborator
LucasLefevre
left a comment
LucasLefevre
left a comment
There was a problem hiding this comment.
robodoo r+ rebase-ff
| const msg: CollaborationMessage = deepCopy(message); | ||
| // simulates network serialization, which removes undefined values of an object, | ||
| // contrary to deepCopy | ||
| const msg: CollaborationMessage = JSON.parse(JSON.stringify(message)); |
Collaborator
|
Merge method set to rebase and fast-forward. |
robodoo
pushed a commit
that referenced
this pull request
Jan 9, 2026
The mock transport service did not serialize the messages the same way
it would occur in real life.
```ts
JSON.parse(JSON.stringify({ a: undefined })) === {}
deepCopy({ a: undefined }) === { a: undefined }
```
Task: 5441149
Part-of: #7692
Signed-off-by: Lucas Lefèvre (lul) <[email protected]>
robodoo
pushed a commit
that referenced
this pull request
Jan 9, 2026
The command UPDATE_CELL was designed so that any style passed to it would simply overwrite the cell style. This differs from the SET_FORMATTING command and unfortunately, the distinction was lost during recent split of style from the cells. closes #7692 Task: 5441149 Signed-off-by: Lucas Lefèvre (lul) <[email protected]>
Collaborator
|
@rrahir @LucasLefevre staging failed: ci/runbot (view more at https://runbot.odoo.com/runbot/batch/2311815/build/97556437) |
The mock transport service did not serialize the messages the same way
it would occur in real life.
```ts
JSON.parse(JSON.stringify({ a: undefined })) === {}
deepCopy({ a: undefined }) === { a: undefined }
```
Task: 5441149
The command UPDATE_CELL was designed so that any style passed to it would simply overwrite the cell style. This differs from the SET_FORMATTING command and unfortunately, the distinction was lost during recent split of style from the cells. Task: 5441149
rrahir
force-pushed
the
saas-19.1-fix-update-cell-style-change-rar
branch
from
de4d63e to
c8842ea
Compare
robodoo
pushed a commit
that referenced
this pull request
Jan 9, 2026
The mock transport service did not serialize the messages the same way
it would occur in real life.
```ts
JSON.parse(JSON.stringify({ a: undefined })) === {}
deepCopy({ a: undefined }) === { a: undefined }
```
Task: 5441149
Part-of: #7692
Signed-off-by: Lucas Lefèvre (lul) <[email protected]>
robodoo
pushed a commit
that referenced
this pull request
Jan 9, 2026
The command UPDATE_CELL was designed so that any style passed to it would simply overwrite the cell style. This differs from the SET_FORMATTING command and unfortunately, the distinction was lost during recent split of style from the cells. closes #7692 Task: 5441149 Signed-off-by: Lucas Lefèvre (lul) <[email protected]>
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
[FIX] tests: fix network serialization in mock
The mock transport service did not serialize the messages the same way
it would occur in real life.
[FIX] Style: UPDATE_CELL overwrites the cell style
The command UPDATE_CELL was designed so that any style passed to it
would simply overwrite the cell style. This differs from the
SET_FORMATTING command and unfortunately, the distinction was lost
during recent split of style from the cells.
Task: 5441149
review checklist