fix(vector_io): propagate search errors instead of returning empty results#6093
Open
derekhiggins wants to merge 2 commits into
Open
fix(vector_io): propagate search errors instead of returning empty results#6093derekhiggins wants to merge 2 commits into
derekhiggins wants to merge 2 commits into
Conversation
…sults The catch-all exception handler in openai_search_vector_store was silently swallowing backend errors and returning an empty result set with HTTP 200. This made it impossible for clients to distinguish between "no matching documents" and "the search failed", masking bugs like the milvus-lite 3.0 chunk_content KeyError. Closes ogx-ai#6092 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Derek Higgins <derekh@redhat.com>
derekhiggins
requested review from
bbrowning,
cdoern,
franciscojavierarceo,
leseb,
mattf,
raghotham and
skamenan7
as code owners
…e_with_chunks The test was passing a plain dict filter without a 'type' field, which was silently failing due to the catch-all exception handler returning empty results. The assertion loop never ran, so it appeared to pass. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Derek Higgins <derekh@redhat.com>
cdoern
approved these changes
Jun 12, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Collaborator
|
@Mergifyio backport release-1.1.x |
Contributor
🟠 Waiting for conditions to matchDetails
|
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
mattf
approved these changes
Jun 13, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
except Exceptioninopenai_search_vector_storewas silently swallowing backend errors and returning empty results with HTTP 200chunk_contentKeyError (feat(benchmarking): add Bayesian model fitting and CI workflow #6089), where file_search appeared to work but retrieval silently returned nothingtest_openai_vector_store_with_chunkswhich was passingfilters={"topic": "ai"}(the old shorthand format) instead of the typed format{"type": "eq", "key": "topic", "value": "ai"}required since feat: Enable Filters in OpenAI Search API #4471. The error was silently swallowed, and the assertion loop over empty results never executed, so the test appeared to pass.Closes #6092
Test plan
test_search_vector_store_propagates_backend_errorsthat verifies aKeyErrorfrom the backend propagates to the callertest_openai_vector_store_with_chunksfilter format so it actually exercises the filter path