Multiple issues with OpenAPI specification, leading to incorrect generated classes #1581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clementdenis
requested a review
from arvindkrishnakumar-okta
as a code owner
|
@clementdenis Thanks for your PR! Will take a closer look. |
antprnbackupta
force-pushed
the
fix-openapi-spec
branch
2 times, most recently
from
4cfa56d to
0f82ad6
Compare
antprnbackupta
force-pushed
the
fix-openapi-spec
branch
3 times, most recently
from
224ebf6 to
edd3b32
Compare
antprnbackupta
force-pushed
the
fix-openapi-spec
branch
from
d7b8dea to
048f636
Compare
antprnbackupta
force-pushed
the
fix-openapi-spec
branch
from
b50d4ce to
3b14fd2
Compare
antprnbackupta
force-pushed
the
fix-openapi-spec
branch
from
7cf0b38 to
4c28c6d
Compare
- This generates an empty schema in the Java models
- path parameters must be required - example should match pattern
OpenApi: Update InlineHooks to match the latest spec
…ondition to OktaSignOnPolicyRuleConditions OpenApi: Update InlineHooks to match the latest spec
…orEnrollmentPolicyRuleConditions OpenApi: Update InlineHooks to match the latest spec
OpenApi: Update InlineHooks to match the latest spec
…minLength property OpenApi: Update InlineHooks to match the latest spec
antprnbackupta
force-pushed
the
fix-openapi-spec
branch
from
4c28c6d to
370b8a2
Compare
This reverts commit aa5b826.
antprnbackupta
force-pushed
the
fix-openapi-spec
branch
from
d1721aa to
c74a8ab
Compare
antprnbackupta
force-pushed
the
fix-openapi-spec
branch
2 times, most recently
from
3eeb04f to
9861e06
Compare
antprnbackupta
force-pushed
the
fix-openapi-spec
branch
from
9861e06 to
a1db848
Compare
antprnbackupta
force-pushed
the
fix-openapi-spec
branch
from
b4077f9 to
3f3a8c6
Compare
antprnbackupta
force-pushed
the
fix-openapi-spec
branch
7 times, most recently
from
512368c to
3f3a8c6
Compare
…y in BehaviorRule as it is not formatted correctly
antprnbackupta
force-pushed
the
fix-openapi-spec
branch
from
7dc1207 to
782d3cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are multiple issues in the current API specification that prevent us from using the latest SDK version (since v19).
See the ticket in the OpenAPI spec repository for more details: okta/okta-management-openapi-spec#218
Category
Signoff