Skip to content

Conversation

@giskook
Copy link
Contributor

@giskook giskook commented May 24, 2023

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@codecov-commenter
Copy link

codecov-commenter commented May 24, 2023

Codecov Report

Merging #147 (b196abb) into dev (c830fea) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head b196abb differs from pull request most recent head 6e7f625. Consider uploading reports for the commit 6e7f625 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##              dev     #147   +/-   ##
=======================================
  Coverage   34.53%   34.53%           
=======================================
  Files         429      429           
  Lines       44762    44762           
=======================================
+ Hits        15457    15459    +2     
+ Misses      28156    28155    -1     
+ Partials     1149     1148    -1     

see 1 file with indirect coverage changes

@giskook giskook force-pushed the zhangkai/iavewer-prefix branch from abe180b to 59483eb Compare June 20, 2023 00:17
@giskook giskook force-pushed the zhangkai/iavewer-prefix branch from 59483eb to 6e7f625 Compare June 20, 2023 00:18
@giskook giskook marked this pull request as ready for review June 20, 2023 00:19
@giskook giskook requested a review from cwbhhjl June 20, 2023 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants