Skip to content

Conversation

@ylsGit
Copy link
Contributor

@ylsGit ylsGit commented Jun 6, 2023

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2023

Codecov Report

Merging #171 (671133c) into dev (d2aa341) will decrease coverage by 0.77%.
The diff coverage is 35.71%.

❗ Current head 671133c differs from pull request most recent head dd92690. Consider uploading reports for the commit dd92690 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##              dev     #171      +/-   ##
==========================================
- Coverage   35.18%   34.41%   -0.77%     
==========================================
  Files         375      430      +55     
  Lines       39025    44870    +5845     
==========================================
+ Hits        13729    15444    +1715     
- Misses      24325    28280    +3955     
- Partials      971     1146     +175     
Impacted Files Coverage Δ
app/app_parallel.go 15.00% <10.00%> (ø)
app/ante/account.go 54.38% <100.00%> (ø)
app/app.go 81.18% <100.00%> (ø)

... and 54 files with indirect coverage changes

@LeoGuo621 LeoGuo621 self-requested a review June 15, 2023 02:00
@ylsGit ylsGit marked this pull request as ready for review June 29, 2023 02:36
scf0220
scf0220 previously approved these changes Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants