Skip to content

Conversation

@lyh169
Copy link
Contributor

@lyh169 lyh169 commented Aug 14, 2023

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@codecov-commenter
Copy link

Codecov Report

Merging #208 (39b4154) into dev (e6ed0b9) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 39b4154 differs from pull request most recent head 615b46b. Consider uploading reports for the commit 615b46b to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##              dev     #208      +/-   ##
==========================================
- Coverage   34.45%   34.44%   -0.01%     
==========================================
  Files         430      430              
  Lines       44883    44883              
==========================================
- Hits        15464    15462       -2     
- Misses      28271    28272       +1     
- Partials     1148     1149       +1     

see 1 file with indirect coverage changes

@lyh169 lyh169 requested a review from ItsFunny August 14, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants