support full trace log #55
Draft
+171
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sieniven
reviewed
Jan 16, 2026
Comment on lines
+115
to
+128
| // Log block send start | ||
| { | ||
| use reth_monitor::{get_global_tracer, TransactionProcessId}; | ||
| use alloy_primitives::B256; | ||
| let block_hash = payload.block().hash(); | ||
| let block_number = payload.block().header().number; | ||
| if let Some(tracer) = get_global_tracer() { | ||
| tracer.log_block( | ||
| B256::from(*block_hash), | ||
| block_number, | ||
| TransactionProcessId::SeqBlockSendStart, | ||
| ); | ||
| } | ||
| } |
There was a problem hiding this comment.
Remove this. This is unnecessary because you can add this log directly inside the reth repo instead, since this message will be handled on the engine state tree handler
sieniven
reviewed
Jan 16, 2026
There was a problem hiding this comment.
Standard payload builders are not used and can completely be removed
sieniven
reviewed
Jan 16, 2026
There was a problem hiding this comment.
Standard payload builders are not used and can completely be removed
sieniven
reviewed
Jan 16, 2026
|
|
||
| # reth-monitor for transaction and block monitoring | ||
| # Note: Initialization is done in xlayer-reth, op-rbuilder only uses get_global_tracer() | ||
| reth-monitor = { git = "https://github.com/okx/reth", branch = "leo/support-full-trace" } |
There was a problem hiding this comment.
You should specify the patch version here?
sieniven
reviewed
Jan 16, 2026
Comment on lines
+589
to
+600
| if let Some(payload) = resolve_payload.get() { | ||
| use reth_monitor::{get_global_tracer, TransactionProcessId}; | ||
| let block_hash = payload.block().hash(); | ||
| let block_number = payload.block().header().number; | ||
| if let Some(tracer) = get_global_tracer() { | ||
| tracer.log_block( | ||
| B256::from(*block_hash), | ||
| block_number, | ||
| TransactionProcessId::SeqBlockBuildEnd, | ||
| ); | ||
| } | ||
| } |
There was a problem hiding this comment.
This is incorrect. We should add this inside the resolve_best_payload function, after resolve_payload.set(payload) is set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
💡 Motivation and Context
✅ I have completed the following steps:
make lintmake test