Skip to content

Conversation

@cleobis
Copy link

@cleobis cleobis commented Feb 20, 2021

Would you be interested in allowing events to span multiple days? I have tried implementing it in this pull request. It seems to be working for me but I don't have enough experience with JavaScript to be fully confident in the code. I had to reset the dependencies as the references to http://repo.labs.intellij.net/ in packages-lock.json didn't work for me.

@olegbakhirev
Copy link
Owner

Hi! Thanks for the request, now I'm considering backward compatibility with already created widgets of older versions and how configuration UI should be changed for two fields. As you can see we should add possibility to show end date field based on context selected (only for particular single project having at least two fields of type date/ date and time) for all other cases show two fields in config does not make big sense. So now thinking about it! Thanks again, hope I'll be back shortly

@olegbakhirev
Copy link
Owner

Thanks once again. I've made a review of the implementation. So there are some issues already mentioned in my comment above but with details now:

  1. Config lets you choose both fields even if context is not set to some particular project. In that case we can set even fields from different projects and widgets starts working just as OR operation for both schedule fields which IMO slightly breaks the idea.
  2. Suggest only in case if particular project is selected in context (single project) and this project has two fields of date/date-time simultaneously we can show both options schedule start\end date. Then it makes sense I suppose
  3. I've dome some testing - change of context to some other project does not work correctly anymore. So set some project in context and its fields as scheduled fields.Then go to config and try change context to some other project with date fields - and I can't select them in schedule fields. So it requires some debugging and fixing
  4. We should remove all console.log(...) such as console.log("Query = " + issuesQuery);
  5. I have created an issue https://youtrack.jetbrains.com/issue/JT-62778 to check how often users require this case and hope they'll upvote the idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants