Skip to content

perf: speed up deepClone with large number of circular refs #4734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lukecotter wants to merge 2 commits into
base: master
Choose a base branch
from
Open

perf: speed up deepClone with large number of circular refs #4734

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90f15dc
perf: use weak map to track circular refs
lukecotter Apr 11, 2025
c293c0f
fix: add missing set in map
lukecotter Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 17 additions & 25 deletions src/js/core/tools/Helpers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,38 +1,36 @@
export default class Helpers{

static elVisible(el){
export default class Helpers {
static elVisible(el) {
return !(el.offsetWidth <= 0 && el.offsetHeight <= 0);
}

static elOffset(el){
static elOffset(el) {
var box = el.getBoundingClientRect();

return {
top: box.top + window.pageYOffset - document.documentElement.clientTop,
left: box.left + window.pageXOffset - document.documentElement.clientLeft
left: box.left + window.pageXOffset - document.documentElement.clientLeft,
};
}

static retrieveNestedData(separator, field, data){
static retrieveNestedData(separator, field, data) {
var structure = separator ? field.split(separator) : [field],
length = structure.length,
output;

for(let i = 0; i < length; i++){
length = structure.length,
output;

for (let i = 0; i < length; i++) {
data = data[structure[i]];

output = data;

if(!data){
if (!data) {
break;
}
}

return output;
}

static deepClone(obj, clone, list = []){
static deepClone(obj,clone, circularRefs = new WeakMap()){
var objectProto = {}.__proto__,
arrayProto = [].__proto__;

Expand All @@ -41,22 +39,16 @@ export default class Helpers{
}

for(var i in obj) {
let subject = obj[i],
match, copy;

let subject = obj[i];
if(subject != null && typeof subject === "object" && (subject.__proto__ === objectProto || subject.__proto__ === arrayProto)){
match = list.findIndex((item) => {
return item.subject === subject;
});

if(match > -1){
clone[i] = list[match].copy;
const match = circularRefs.get(subject);
if(match){
clone[i] = match;
}else{
copy = Object.assign(Array.isArray(subject) ? [] : {}, subject);

list.unshift({subject, copy});
const copy = Object.assign(Array.isArray(subject) ? [] : {}, subject);
circularRefs.set(obj, copy);

clone[i] = this.deepClone(subject, copy, list);
clone[i] = this.deepClone(subject, copy, circularRefs);
}
}
}
Expand Down
Loading