Add styles for success state in Tabulator alerts #4816
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Hey @hichxm, I think the alert is only useful for loading and error state, but I might be missing something. I'm curious what's the use case of this PR? |
Author
|
For enhanced visual accessibility, an alert message such as “Updated successfully…” should be displayed. |
Collaborator
|
Thanks for the PR. To keep the codebase clean, we're not adding a new class since this isn't a built-in state. This can be added in your own stylesheet instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request introduces styles for the success state in Tabulator alerts. These changes enhance the visual representation of successful operations.
Details of Changes