Feat/native(chore): restart controls by Vidarte-Alberto · Pull Request #748 · olympus-btc/ambrosia

Vidarte-Alberto · 2026-09-09T04:11:55Z

Problem

Ambrosia had no way to restart the server or phoenixd from the app itself. If either process needed to pick up a config change, recover from a stuck state, or apply a pending settings change, the only options were a manual terminal/systemctl command (native installs), physically rebooting the device (hardware), or restarting containers by hand (Docker) — with zero in-app control. Electron already had the plumbing for this internally (services:restart IPC), but it was never exposed as an actual button, and no other deployment mode had anything at all.

Fix

Added "Restart server" / "Restart phoenixd" controls to Settings, working across every deployment mode — native (systemd), the Raspberry Pi/OrangePi hardware image, Docker, and Electron — by reusing each mode's own existing process supervisor (systemd Restart=always, Docker restart: unless-stopped, Electron's ServiceManager) instead of introducing new privileges like passwordless sudo or polkit rules. phoenixd is signalled directly via a pidfile since it runs as the same OS user as the server on native/hardware installs; on Docker it correctly has no way to be reached (separate container, separate PID namespace) so only the server button is shown there.

What Changed

Added canRestartSelf()/isSystemdManaged()/isLocalPhoenixd() server helpers to detect when a self-restart is safe.
Generalized the existing Docker-only restart (scheduleDockerRestart) into scheduleProcessRestart, now also used for systemd-managed native/hardware installs.
Forced the process to exitProcess after stopping the embedded server — a leaked non-daemon thread from the Web Push async HTTP client was silently keeping the JVM alive after stopSuspend(), so the process never actually restarted.
Added PhoenixdProcessService, which signals phoenixd through a pidfile.
Added admin-only /system/restart-capabilities, /system/restart-server, /system/restart-phoenixd endpoints.
Added run-server.sh / run-phoenixd.sh self-restart wrappers with signal forwarding, so systemctl stop still stops the process cleanly instead of fighting the restart loop.
Wired the phoenixd wrapper and an AMBROSIA_SERVICE_MANAGED flag into install.sh and the hardware image's systemd units.
Added an install.sh --local flag that builds and installs from the current checkout instead of downloading a GitHub release; updated uninstall.sh to remove the new wrapper too.
Added a "System" Settings card with a confirmation modal for each restart action, styled to match the Close Channel danger buttons.
Fixed two unrelated pre-existing bugs found while testing this end-to-end: a malformed fallback wordlist URL in SeedGenerator (a stray triple-quoted string embedded newlines into the URL) that broke server boot on any fresh install without the local wordlist file, and the Docker client not binding to 0.0.0.0, which made its own middleware unable to reach itself for the onboarding check.

How to Test

Native: ./scripts/install.sh --local --yes, log in as admin, go to Settings → System, click "Restart server" and confirm — the service should actually come back. Same for "Restart phoenixd".
Hardware: build and flash the OrangePi/RPi image, boot the device, repeat the same two checks.
Docker: docker compose up --build -d, confirm only "Restart server" is shown (not phoenixd), and that clicking it restarts the ambrosia container.
Electron: confirm both buttons work via the existing services:restart IPC channel.
Confirm neither button appears on a deployment with no supervisor (e.g. a --no-service install).

Verification

Server: ./gradlew test ktlintCheck passed.
Client: full Jest suite passed (306 suites, 2905 tests), ESLint clean.
All new/modified shell scripts pass bash -n.
Manually verified end-to-end on native, hardware (real device flash + boot), Docker, and Electron.

Screenshots

…Restart for any supervised process.

…t actually restarts.

…nixd.

…s its pid.

…server as service-managed.

…t instead of a GitHub release.

…local.

…estarts.

…r styling.

…-restart.

…all.sh.

…tself internally.

…s in update.sh.

… wrapper isn't published yet.

Sharmaz · 2026-09-10T17:26:04Z

+  const state = { ...defaults, ...overrides };
+  jest.spyOn(useSystemRestartHook, "useSystemRestart").mockReturnValue(state);
+  return state;


Avoid generic variables as state in the all file.

Sharmaz · 2026-09-10T17:27:38Z

+      const { result } = renderHook(() => useSystemRestart());
+
+      await act(async () => {
+        await result.current.loadRestartCapabilities();
+      });


Avoid generic variables as result in the whole document.

Sharmaz · 2026-09-10T17:28:23Z

+      let returnValue;
+      await act(async () => {
+        returnValue = await result.current.restartServer();


Be more specific with the variable names returnValue is meaningless

Sharmaz · 2026-09-10T17:33:20Z

+        val deadProcess = ProcessBuilder("true").start()
+        deadProcess.waitFor()
+        val pidFile = newPidFile().apply { writeText(deadProcess.pid().toString()) }
+        val service = PhoenixdProcessService(pidFile = pidFile)


Avoid generic variables as service in the whole document.

Sharmaz · 2026-09-10T17:33:51Z

+    @Test
+    fun `isLocalPhoenixd is false when phoenixd-remote is enabled`() =
+        testApplication {
+            environment { config = MapApplicationConfig("phoenixd-remote" to "true") }


Avoid generic variables as config in the whole document.

Config here isn't a local variable we're naming, it's the config property on Ktor's ApplicationEngineEnvironmentBuilder, set via the environment { config = ... } test DSL (ktor-server-test-host).

Sharmaz

LGTM!

… start before the backend is ready.

ca-ruz

ACK.

Built and tested locally, works as expected.

Phoenixd Restart:

Server Restart:

Vidarte-Alberto added 22 commits September 8, 2026 20:00

feat(server): add helpers to detect self-restart capability.

4bbb99c

refactor(server): generalize scheduleDockerRestart to scheduleProcess…

161a5ac

…Restart for any supervised process.

fix(server): force the process to exit after stopping the server so i…

23471dd

…t actually restarts.

feat(server): add phoenixd process control via pidfile signaling.

b5edde5

feat(server): expose /system endpoints to restart the server and phoe…

78da5f4

…nixd.

feat(scripts): restart the server automatically when the process exits.

0c530ed

feat(scripts): add a phoenixd wrapper that restarts on exit and track…

e6fc389

…s its pid.

feat(install): run phoenixd through the restart wrapper and flag the …

7e256a4

…server as service-managed.

feat(install): add a --local flag to install from the current checkou…

237bba7

…t instead of a GitHub release.

feat(install): build the server jar and client automatically under --…

5138acb

…local.

feat(client): add a hook and service to trigger server and phoenixd r…

c6b23fe

…estarts.

feat(client): add a Settings card to restart the server and phoenixd.

c805427

style(client): match restart button colors to the close channel dange…

bfa1842

…r styling.

feat(hardware): flag the ambrosia service as service-managed for self…

8de1900

…-restart.

feat(hardware): route phoenixd through the restart wrapper.

7dc7d0c

fix(uninstall): remove the phoenixd restart wrapper installed by inst…

1c95922

…all.sh.

fix(server): remove malformed whitespace from the fallback wordlist URL.

be7dbd9

fix(docker): bind the client to 0.0.0.0 so the middleware can reach i…

b611450

…tself internally.

refactor(server): use descriptive variable names in SeedGenerator.

5caca19

feat(scripts): retrofit the phoenixd restart wrapper and service flag…

06d8fd4

…s in update.sh.

fix(install): use find instead of ls to satisfy shellcheck.

e715b4a

fix(install): fall back to the plain phoenixd binary when the restart…

31450ff

… wrapper isn't published yet.

Vidarte-Alberto marked this pull request as ready for review September 9, 2026 05:18

Vidarte-Alberto linked an issue Sep 9, 2026 that may be closed by this pull request

Add owner-only recovery controls for Lightning, Ambrosia, and device restart/shutdown #741

Open

Sharmaz reviewed Sep 10, 2026

View reviewed changes

Sharmaz requested changes Sep 10, 2026

View reviewed changes

refactor: use descriptive variable names in restart control tests.

61b6356

Vidarte-Alberto requested a review from Sharmaz September 10, 2026 18:13

Sharmaz approved these changes Sep 10, 2026

View reviewed changes

fix(install): order the client service after the server so it doesn't…

c1cf843

… start before the backend is ready.

ca-ruz approved these changes Sep 10, 2026

View reviewed changes

Vidarte-Alberto merged commit 499d851 into olympus-btc:development Sep 10, 2026
16 checks passed

Navigation Menu

Uh oh!

Feat/native(chore): restart controls - #748

Feat/native(chore): restart controls#748
Vidarte-Alberto merged 24 commits into
olympus-btc:developmentfrom
Vidarte-Alberto:feat/native-restart-controls

Vidarte-Alberto commented Sep 9, 2026 •

edited

Loading

Uh oh!

Sharmaz Sep 10, 2026

Uh oh!

Sharmaz Sep 10, 2026

Uh oh!

Sharmaz Sep 10, 2026

Uh oh!

Sharmaz Sep 10, 2026

Uh oh!

Sharmaz Sep 10, 2026

Uh oh!

Vidarte-Alberto Sep 10, 2026

Uh oh!

Sharmaz left a comment

Uh oh!

ca-ruz left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Vidarte-Alberto commented Sep 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Fix

What Changed

How to Test

Verification

Screenshots

Uh oh!

Sharmaz Sep 10, 2026

Choose a reason for hiding this comment

Uh oh!

Sharmaz Sep 10, 2026

Choose a reason for hiding this comment

Uh oh!

Sharmaz Sep 10, 2026

Choose a reason for hiding this comment

Uh oh!

Sharmaz Sep 10, 2026

Choose a reason for hiding this comment

Uh oh!

Sharmaz Sep 10, 2026

Choose a reason for hiding this comment

Uh oh!

Vidarte-Alberto Sep 10, 2026

Choose a reason for hiding this comment

Uh oh!

Sharmaz left a comment

Choose a reason for hiding this comment

Uh oh!

ca-ruz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Vidarte-Alberto commented Sep 9, 2026 •

edited

Loading