Skip to content

add missing nullcheck in critnib #1176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/critnib/critnib.c
Original file line number Diff line number Diff line change
Expand Up @@ -537,6 +537,11 @@ find_predecessor(struct critnib_node *__restrict n) {
}

utils_atomic_load_acquire_ptr((void **)&n->child[nib], (void **)&n);

if (!n) {
return NULL;
}

if (is_leaf(n)) {
return to_leaf(n);
}
Expand Down Expand Up @@ -650,6 +655,11 @@ static struct critnib_leaf *find_successor(struct critnib_node *__restrict n) {
}

n = n->child[nib];

if (!n) {
return NULL;
}

if (is_leaf(n)) {
return to_leaf(n);
}
Expand Down
Loading