-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Editor sanding #2996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Editor sanding #2996
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the start of the multi-side / all side dropdown adjustment
|
|
||
| const [activeTab, setActiveTab] = useState<MarginTab>(areAllMarginsEqual ? MarginTab.ALL : MarginTab.INDIVIDUAL); | ||
|
|
||
| // Track if user is actively interacting with the input |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to the border component, the margin component duplicates isUserInteracting logic. Consider refactoring this into a shared hook.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Multi-side / all side dropdown adjustment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Attempt to fix the letter spacing / lineheight breaking bug
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added additional context
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add-on to fix the letter spacing / lineheight breaking bug
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beggining to adjust the context pop-up. Ok to not include this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This helps the user understand why they can't start a new chat while the AI is running. Preference is to keep this if we can.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Telling the user that something is happening when they are creating a new project with a "loading" state in the project breadcrumb in the upper left corner
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Telling the user that something is happening when they are creating a new project with a "loading" state in the project breadcrumb in the upper left corner
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Component for setting up Telling the user that something is happening when they are creating a new project with a "loading" state in the project breadcrumb in the upper left corner
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Loading state in the upper-right corner for the white "create" button in the projects page to tell the user the project is being created
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the mobile window from initial project load. Got feedback that it was confusing to people on startup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adjust the placement of the desktop frame now that the mobile view isn't there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improve styling of the scroll-down arrow that appears in the conversation chat so users can see it.
Description
– Improve loading states between projects that are created from the editor
– Improve UI of the scroll down arrow in the AI chat
– Improve styling of AI context (Still in progress)
– Added loading messages for the webframe to entertain the user
– Loading animation for creating from the project page to tell the user something is happenign.
Type of Change
Important
Improves UI/UX in the editor with enhanced loading states, dropdown interactions, and introduces a new loading management system for project actions.
new-project-menu.tsxandproject-breadcrumb.tsx.chat-context.tsx.new-project-menu.tsxandproject-breadcrumb.tsx.border.tsx,margin.tsx,padding.tsx, andradius.tsx.use-input-control.tsto handle negative values, min/max bounds, and step sizes.use-project-loading.tsxto manage loading states for project actions.new-project-menu.tsx,project-breadcrumb.tsx, andrecent-projects.tsx.fork.tsandproject.ts.frame.ts.This description was created by
for 6ef4dd0. You can customize this summary. It will automatically update as commits are pushed.