Skip to content

WIP: Fix lint to make it not create breaking diffs #3014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Parent: Fix all cyclical dependencies in repo, resolve all typecheck issues in all packages, set up sherif to avoid future issues due to package mismatches
wants to merge 1 commit into
base: run-lint-on-repo
Choose a base branch
from
Open

WIP: Fix lint to make it not create breaking diffs #3014

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions tooling/eslint/base.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,11 @@ export default tseslint.config(
varsIgnorePattern: '^_',
},
],
'@typescript-eslint/consistent-type-imports': [
'warn',
{ prefer: 'type-imports', fixStyle: 'inline-type-imports' },
],
// Disabled: Let prettier handle type import style via @ianvs/prettier-plugin-sort-imports
// '@typescript-eslint/consistent-type-imports': [
// 'warn',
// { prefer: 'type-imports', fixStyle: 'separate-type-imports' },
// ],
'@typescript-eslint/no-misused-promises': [
2,
{ checksVoidReturn: { attributes: false } },
Expand All @@ -73,7 +74,6 @@ export default tseslint.config(
},
],
'@typescript-eslint/no-non-null-assertion': 'error',
'import/consistent-type-specifier-style': ['error', 'prefer-top-level'],
},
},
{
Expand Down
2 changes: 1 addition & 1 deletion tooling/prettier/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ const config = {
'^[./]',
],
importOrderParserPlugins: ['typescript', 'jsx', 'decorators-legacy'],
importOrderTypeScriptVersion: '4.4.0',
importOrderTypeScriptVersion: '5.8.2',
};

export default config;