Fix Assertion Const Node Tensor Request when Node has value_int Rather than Value#181
Merged
justinchuby merged 2 commits intoonnx:mainfrom Jul 1, 2025
Conversation
ghost
approved these changes
May 6, 2025
ghost
approved these changes
May 6, 2025
ghost
approved these changes
May 6, 2025
…g for a tensor and not another attribute like value_int Signed-off-by: Joshua Monson <joshmonson@microsoft.com>
jsmonson
force-pushed
the
bugfix/fix-const-value-int-assertion-failure
branch
from
169b80b to
2d93792
Compare
justinchuby
approved these changes
May 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a check to extract_constant_to_initializer and the FetchConstantTensor function (in pass_util.h) that ensures the constant node actually contains a Tensor (rather than a value_int or some other type). If not checked, this causes an assertion failure when these pass and function are used.
See Issue: #173