Bump CMake minimum version to 3.24 for Python 3.13 compatibility - #243
Closed
justinchuby with Copilot wants to merge 4 commits into
Closed
Bump CMake minimum version to 3.24 for Python 3.13 compatibility#243justinchuby with Copilot wants to merge 4 commits into
justinchuby with Copilot wants to merge 4 commits into
Conversation
Co-authored-by: justinchuby <11205048+justinchuby@users.noreply.github.com>
Co-authored-by: justinchuby <11205048+justinchuby@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix build failure for onnxoptimizer on macOS with Python 3.13
Bump CMake minimum version to 3.24 for Python 3.13 compatibility
Dec 31, 2025
|
justinchuby
approved these changes
Dec 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Building from source fails on Python 3.13 due to CMake version mismatch between main project (3.22) and onnx submodule (3.24).
Changes
cmake_minimum_requiredfrom 3.22 to 3.24 to match onnx submodule requirement-DCMAKE_POLICY_VERSION_MINIMUM=3.5workaroundThe workaround was added when submodules had ancient CMake requirements (<3.5). Current submodule versions require modern CMake (protobuf: 3.16+, onnx: 3.24), making the workaround obsolete.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.