Skip to content

Fix typo in variable name 'bn_bais' to 'bn_bias'#299

Merged
andife merged 2 commits intoonnx:mainfrom
junminjang:patch-1
Apr 19, 2026
Merged

Fix typo in variable name 'bn_bais' to 'bn_bias'#299
andife merged 2 commits intoonnx:mainfrom
junminjang:patch-1

Conversation

@junminjang
Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: junminjjang <junminjang@hanyang.ac.kr>
@andife
Copy link
Copy Markdown
Member

andife commented Apr 19, 2026

@junminjang Thank you very much for your contribution

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR corrects a typo in the BatchNorm fusion pass by renaming the local variable bn_bais to bn_bias, improving readability and reducing confusion in the BN-into-Conv transformation logic.

Changes:

  • Rename bn_bais to bn_bias and update all local references in the pass.
  • Update related assertions and initializer wiring to use the corrected name.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread onnxoptimizer/passes/fuse_bn_into_conv.h Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
@sonarqubecloud
Copy link
Copy Markdown

@andife andife merged commit 4a550bb into onnx:main Apr 19, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants