Add electrode X/Y positions to the XML file #137
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing this PR for now, as it would not have the intended effect even if it were merged. For updates, check out the Probe Interface issue posted here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the electrode X/Y positions to the XML file, similar to how the Neuropixels PXI plugin adds them.
Note: During this process, it was noted that the absolute X/Y positions are slightly different between the PXI plugin and the ONIX Source plugin (both of which are slightly different than the positions found in the SpikeInterface repo). If this is a potential issue, then we need to choose what the offset should be, and standardize it across both plugins as well as the Onix1 library.