Update Rhs2116 GUI page #276
Conversation
There was a problem hiding this comment.
Looks good, though I do find it a little odd that there are labels for negative channels
I know that this discussion would technically belong in the bonsai-onix1 repo, but I don't wanna make an issue for it if it's not necessary (e.g. if y'all have discussed it and decided it's nbd).
Other than that, just consider my one other comment, and then feel free to merge.
|
it's not really part of this PR, but I did feel like maybe it's kinda difficult to see what's going on in these probeinterface screenshots because of their size: |
- Update images to show the new UI - Remove old images - Update text, and resize images to fit better on the screen at the current resolution
|
@cjsha regarding the comment about channel labels, I've opened a new issue in the Onix1 library to track this, and so we can discuss if it is worth pursuing. You have a point that the ProbeInterface screenshots are a little small, but as long as they serve their purpose of indicating that any 32-channel probe can be used I think they are okay for now. We can open a new issue and discuss further if it should be modified. |
Fixes #275
Fixes #176