Skip to content

feat: add free shipping banner#34

Closed
beeme1mr wants to merge 2 commits intomainfrom
shop-4287/add-shipping-banner
Closed

feat: add free shipping banner#34
beeme1mr wants to merge 2 commits intomainfrom
shop-4287/add-shipping-banner

Conversation

@beeme1mr
Copy link
Member

@beeme1mr beeme1mr commented Nov 6, 2025

No description provided.

Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Copilot AI review requested due to automatic review settings November 6, 2025 19:35
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR renames a feature flag from offer-free-shipping to free-shipping-banner to better reflect its purpose of controlling a banner display. The changes update both the flag definition and its usage in the application code.

  • Renamed feature flag key and corresponding React hook
  • Updated flag description to include ticket reference and clarify purpose

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
src/app/page.tsx Updates React hook import and usage to match renamed feature flag
flags.json Renames flag key and enhances description with ticket reference

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@gemini-code-assist
Copy link

Summary of Changes

Hello @beeme1mr, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on refining the naming convention for a feature flag related to free shipping. The offer-free-shipping flag has been renamed to free-shipping-banner to provide a clearer indication of its purpose, which is to control the visibility of a free shipping banner on the website. The changes include updating the flag definition, modifying the React component that consumes this flag, and regenerating the OpenFeature client-side SDK hooks to align with the new naming and enhance type consistency across all generated flag hooks.

Highlights

  • Feature Flag Renaming: The offer-free-shipping feature flag has been renamed to free-shipping-banner to more accurately reflect its function of controlling a UI banner.
  • OpenFeature Hook Updates: The generated OpenFeature React hooks have been updated to reflect the new flag name, including the useFreeShippingBanner and useSuspenseFreeShippingBanner hooks. Additionally, explicit FlagQuery<boolean> return types have been added to all generated flag hooks for improved type safety.
  • FlagKeys Constant: A new FlagKeys constant has been introduced in the generated OpenFeature file, providing programmatic access to flag keys, including the newly named FREE_SHIPPING_BANNER.
  • UI Component Integration: The src/app/page.tsx component has been updated to use the new useSuspenseFreeShippingBanner hook, ensuring the UI correctly responds to the renamed feature flag.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the feature flag for the shipping banner by renaming it from offer-free-shipping to free-shipping-banner, which improves clarity. The changes are consistently applied across flags.json, the component in src/app/page.tsx, and the generated hooks in src/generated/react/openfeature.ts. Additionally, you've made some great improvements to the generated hooks file by adding explicit return types and introducing a FlagKeys constant for safer flag access. I have a couple of suggestions to further improve the maintainability by using this new constant within the hooks file itself.

Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
@beeme1mr beeme1mr closed this Nov 6, 2025
@beeme1mr beeme1mr reopened this Nov 6, 2025
@beeme1mr beeme1mr closed this Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants