Skip to content

Fix (#27660): Re-enable Exasol cli-e2e-tests after fixing issues#27661

Open
ArBridgeman wants to merge 3 commits intoopen-metadata:mainfrom
exasol:fix/enable-exasol-cli-e2e-tests
Open

Fix (#27660): Re-enable Exasol cli-e2e-tests after fixing issues#27661
ArBridgeman wants to merge 3 commits intoopen-metadata:mainfrom
exasol:fix/enable-exasol-cli-e2e-tests

Conversation

@ArBridgeman
Copy link
Copy Markdown
Contributor

@ArBridgeman ArBridgeman commented Apr 23, 2026

Describe your changes:

Fixes #27660

To re-enable the Exasol cli-e2e-tests, I:

  • set up my local environment per OpenMetadata's documentation, including the pre-commit hooks
  • updated the installed ITDE in the setup.py
  • modified the test setup in ingestion/tests/cli_e2e/test_cli_exasol.py
  • ran all tests locally in my VM
  • added additional information for contacting us if issues arise again
  • added "exasol" again in the .github/workflows/py-cli-e2e-tests.yml

I worked on the tests because we would like to ensure that the Exasol connector continues to work.
Most of our tests are centralized in the ingestion/tests/cli_e2e/test_cli_exasol.py, so it is critical that these are regular run, and if there are issues, it would be helpful if we were contacted.

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Bug Fix

  • I have added a test that covers the exact scenario we are fixing. For complex issues, comment the issue number in the test for future reference.

Summary by Gitar

  • Test configuration updates:
    • Updated DB_VERSION to 2025.1.8 and modified create_table_query to use DOUBLE PRECISION instead of DECIMAL.
    • Simplified create_view_query to explicitly select columns and updated view_column_lineage_count from 22 to 7.
    • Added a test_vanilla_ingestion method marked with @pytest.mark.skip.
  • Environment and workflow changes:
    • Explicitly added docker pull for the specified DB_VERSION image during test setup.
    • Updated exasol.yaml to set tls to ignore-certificate and disabled includeDDL.

This will update automatically on new commits.

@github-actions
Copy link
Copy Markdown
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@github-actions
Copy link
Copy Markdown
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@github-actions
Copy link
Copy Markdown
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@gitar-bot
Copy link
Copy Markdown

gitar-bot Bot commented Apr 23, 2026

Code Review ✅ Approved

Re-enables the Exasol cli-e2e-tests by resolving the underlying issues blocking execution. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@sonarqubecloud
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown
Contributor

🔴 Playwright Results — 1 failure(s), 10 flaky

✅ 3051 passed · ❌ 1 failed · 🟡 10 flaky · ⏭️ 81 skipped

Shard Passed Failed Flaky Skipped
🟡 Shard 1 477 0 4 4
🟡 Shard 2 655 0 1 7
✅ Shard 3 666 0 0 1
🟡 Shard 4 644 0 4 27
🔴 Shard 5 609 1 1 42

Genuine Failures (failed on all attempts)

Pages/Glossary.spec.ts › Add and Remove Assets (shard 5)
�[31mTest timeout of 180000ms exceeded.�[39m
🟡 10 flaky test(s) (passed on retry)
  • Flow/Tour.spec.ts › Tour should work from help section (shard 1, 1 retry)
  • Flow/Tour.spec.ts › Tour should work from welcome screen (shard 1, 1 retry)
  • Flow/Tour.spec.ts › Tour should work from URL directly (shard 1, 1 retry)
  • Pages/AuditLogs.spec.ts › should apply both User and EntityType filters simultaneously (shard 1, 1 retry)
  • Features/BulkEditEntity.spec.ts › Glossary (shard 2, 1 retry)
  • Pages/Customproperties-part2.spec.ts › entityReferenceList shows item count, scrollable list, no expand toggle (shard 4, 1 retry)
  • Pages/DataContracts.spec.ts › Create Data Contract and validate for Table (shard 4, 1 retry)
  • Pages/DataContractsSemanticRules.spec.ts › Validate UpdatedOn Rule Not_Between (shard 4, 1 retry)
  • Pages/Entity.spec.ts › Delete Container (shard 4, 1 retry)
  • Pages/ExplorePageRightPanel.spec.ts › Should allow Data Consumer to edit tier for table (shard 5, 1 retry)

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Re-enable Exasol's ingestion/tests/cli_e2e/test_cli_exasol.py tests

2 participants