Skip to content

Fixed data Assest lineage spec#27671

Open
Rohit0301 wants to merge 1 commit intomainfrom
fix-data-assest-lineage
Open

Fixed data Assest lineage spec#27671
Rohit0301 wants to merge 1 commit intomainfrom
fix-data-assest-lineage

Conversation

@Rohit0301
Copy link
Copy Markdown
Contributor

@Rohit0301 Rohit0301 commented Apr 23, 2026

Describe your changes:

Column level lineage test - test is getting timed out
data asset lineage spec - click in canvas is flaky

Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Rohit0301 Rohit0301 self-assigned this Apr 23, 2026
@Rohit0301 Rohit0301 requested a review from a team as a code owner April 23, 2026 14:08
@Rohit0301 Rohit0301 added the safe to test Add this label to run secure Github workflows on PRs label Apr 23, 2026
Comment thread openmetadata-ui/src/main/resources/ui/playwright/utils/lineage.ts
@gitar-bot
Copy link
Copy Markdown

gitar-bot Bot commented Apr 23, 2026

Code Review ✅ Approved 1 resolved / 1 findings

Updates the data asset lineage specification for improved accuracy. No issues found.

✅ 1 resolved
Quality: dispatchEvent('click') bypasses Playwright actionability checks

📄 openmetadata-ui/src/main/resources/ui/playwright/utils/lineage.ts:514-516
Using dispatchEvent('click') instead of .click() bypasses Playwright's built-in actionability checks (e.g., ensuring the element is not obscured by overlays, is enabled, etc.). While this works around a flaky test, it may mask real UI issues where the button is covered or not truly interactive. The explicit waitFor({ state: 'visible' }) only partially compensates — visibility doesn't guarantee the element is unobscured or clickable.

Consider using .click({ force: true }) instead, which still uses Playwright's click mechanism but skips the actionability checks. Alternatively, investigate why the standard .click() was failing (e.g., an overlay or animation) and fix the root cause.

Options

Display: compact → Showing less information.

Comment with these commands to change:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@github-actions
Copy link
Copy Markdown
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 61%
61.98% (61732/99597) 42.09% (32990/78372) 45.14% (9763/21626)

@sonarqubecloud
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 23, 2026

🔴 Playwright Results — 1 failure(s), 22 flaky

✅ 3943 passed · ❌ 1 failed · 🟡 22 flaky · ⏭️ 86 skipped

Shard Passed Failed Flaky Skipped
🟡 Shard 1 296 0 2 4
🟡 Shard 2 750 0 9 8
🟡 Shard 3 728 0 4 7
🟡 Shard 4 750 0 2 18
✅ Shard 5 687 0 0 41
🔴 Shard 6 732 1 5 8

Genuine Failures (failed on all attempts)

Pages/Users.spec.ts › Check permissions for Data Steward (shard 6)
ReferenceError: getApiContext is not defined
🟡 22 flaky test(s) (passed on retry)
  • Pages/AuditLogs.spec.ts › should apply both User and EntityType filters simultaneously (shard 1, 1 retry)
  • Pages/UserCreationWithPersona.spec.ts › Create user with persona and verify on profile (shard 1, 1 retry)
  • Features/ActivityAPI.spec.ts › Activity event is created when description is updated (shard 2, 1 retry)
  • Features/ActivityAPI.spec.ts › Activity event shows the actor who made the change (shard 2, 1 retry)
  • Features/CuratedAssets.spec.ts › Test ML Model with display name filter (shard 2, 1 retry)
  • Features/DomainFilterQueryFilter.spec.ts › Assets from selected domain should be visible in explore page (shard 2, 1 retry)
  • Features/DomainFilterQueryFilter.spec.ts › Subdomain assets should be visible when parent domain is selected (shard 2, 1 retry)
  • Features/DomainFilterQueryFilter.spec.ts › Domain filter should persist across page navigation (shard 2, 1 retry)
  • Features/DomainFilterQueryFilter.spec.ts › Domain filter should work with different asset types (shard 2, 2 retries)
  • Features/DomainFilterQueryFilter.spec.ts › Search suggestions should be filtered by selected domain (shard 2, 1 retry)
  • Features/Glossary/GlossaryTermDetails.spec.ts › should add and remove references from glossary term (shard 2, 1 retry)
  • Features/RTL.spec.ts › Verify Following widget functionality (shard 3, 1 retry)
  • Features/Tasks/DomainFiltering.spec.ts › entity page activity feed refetches when domain is switched (shard 3, 1 retry)
  • Features/TestSuiteMultiPipeline.spec.ts › TestSuite multi pipeline support (shard 3, 1 retry)
  • Flow/PersonaFlow.spec.ts › Set default persona for team should work properly (shard 3, 1 retry)
  • Pages/DataContracts.spec.ts › Create Data Contract and validate for Dashboard (shard 4, 1 retry)
  • Pages/DomainDataProductsRightPanel.spec.ts › Should display overview tab content for data product in domain context (shard 4, 1 retry)
  • Pages/Lineage/LineageFilters.spec.ts › Verify lineage schema filter selection (shard 6, 1 retry)
  • Pages/Lineage/LineageRightPanel.spec.ts › Verify custom properties tab IS visible for supported type: searchIndex (shard 6, 1 retry)
  • Pages/Lineage/PlatformLineage.spec.ts › Verify domain platform view (shard 6, 1 retry)
  • Pages/ODCSImportExport.spec.ts › Multi-object ODCS contract - object selector shows all schema objects (shard 6, 1 retry)
  • Pages/ServiceEntity.spec.ts › Announcement create, edit & delete (shard 6, 1 retry)

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants