[processor/resourcedetection] Add OIDC issuer and token path checks for EKS detection#45885
Open
Aneurysm9 wants to merge 2 commits intoopen-telemetry:mainfrom
Open
[processor/resourcedetection] Add OIDC issuer and token path checks for EKS detection#45885Aneurysm9 wants to merge 2 commits intoopen-telemetry:mainfrom
Aneurysm9 wants to merge 2 commits intoopen-telemetry:mainfrom
Conversation
github-actions
bot
added
processor/resourcedetection
paulojmdias
approved these changes
Feb 4, 2026
…or EKS detection EKS changed the `gitVersion` format in Kubernetes 1.35 (platform version eks.3), removing the `-eks-` identifier that the detector relied on. This adds multiple fallback detection methods before the `gitVersion` check: 1. IRSA token path - `AWS_WEB_IDENTITY_TOKEN_FILE` contains "eks.amazonaws.com" 2. Pod Identity token path - `AWS_CONTAINER_AUTHORIZATION_TOKEN_FILE` contains "eks-pod-identity" 3. OIDC issuer - API server `/.well-known/openid-configuration` issuer contains "oidc.eks." 4. Fallback: `gitVersion` contains "-eks-" (existing check) Each positive signal is reasonably conclusive. Errors in earlier checks gracefully fall through to subsequent checks. Fixes open-telemetry#45866 Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
Aneurysm9
force-pushed
the
fix/isEKSDetection
branch
from
21c1bbd to
c6482f0
Compare
Member
Author
|
Fixed the lint issues. The unit test failure seems to be a flake in |
Member
|
Yeah, just comment Thank you again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EKS changed the
gitVersionformat in Kubernetes 1.35 (platform version eks.3), removing the-eks-identifier that the detector relied on. This adds multiple fallback detection methods before thegitVersioncheck:AWS_WEB_IDENTITY_TOKEN_FILEcontains "eks.amazonaws.com"AWS_CONTAINER_AUTHORIZATION_TOKEN_FILEcontains "eks-pod-identity"/.well-known/openid-configurationissuer contains "oidc.eks."gitVersioncontains "-eks-" (existing check)Each positive signal is reasonably conclusive. Errors in earlier checks gracefully fall through to subsequent checks.
Fixes #45866
Description
Link to tracking issue
Fixes
Testing
Documentation