[chore] remove install-tools references #13898
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow up to open-telemetry@8658c56. Some references to `install-tools` were left behind Signed-off-by: alex boten <[email protected]>
Closed
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13898 +/- ##
==========================================
- Coverage 91.67% 91.65% -0.03%
==========================================
Files 652 652
Lines 42516 42516
==========================================
- Hits 38978 38966 -12
- Misses 2730 2739 +9
- Partials 808 811 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
songy23
approved these changes
Sep 24, 2025
dmathieu
approved these changes
Sep 25, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 7, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description This PR ports the `check-codeowners` workflow from the `opentelemetry-collector-contrib` repository. On this side, the command referenced in the workflow is `make generate-codeowners` instead of `make gencodeowners` as is in the contrib version. In the `Makefile`, I added the `-skipgithub` to avoid giving an error like below when the members run it. ```sh 2025/09/25 22:52:36 set the environment variable `GITHUB_TOKEN` to a PAT token to authenticate ``` I ran `gengithub`, which also produced some changes in issue templates. Like the PR #13898, I also removed the `make install-tools` from this workflow. The idea to port this workflow here came from the PR open-telemetry/opentelemetry-collector-contrib#42999 discussion in Slack. --------- Signed-off-by: Paulo Dias <[email protected]>
|
superseeded by #13906 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to 8658c56. Some references to
install-toolswere left behind