Skip to content

[chore][confighttp] use sync.Pool #13909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+12 −1
Open

[chore][confighttp] use sync.Pool #13909

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4597473
[chore][confighttp] use sync.Pool
florianl Sep 26, 2025
2782d52
fixup linter
florianl Sep 26, 2025
9249381
Merge branch 'main' into confighttp-use-syncPool
florianl Sep 29, 2025
e53af78
Merge branch 'main' into confighttp-use-syncPool
codeboten Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion config/confighttp/compression.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ type compressRoundTripper struct {
compressionType configcompression.Type
compressionParams configcompression.CompressionParams
compressor *compressor
bufferPool *sync.Pool
}

var zstdReaderPool sync.Pool
Expand Down Expand Up @@ -179,6 +180,11 @@ func newCompressRoundTripper(rt http.RoundTripper, compressionType configcompres
compressionType: compressionType,
compressionParams: compressionParams,
compressor: encoder,
bufferPool: &sync.Pool{
New: func() any {
return &bytes.Buffer{}
},
},
}, nil
}

Expand All @@ -192,7 +198,12 @@ func (r *compressRoundTripper) RoundTrip(req *http.Request) (*http.Response, err
}

// Compress the body.
buf := bytes.NewBuffer([]byte{})
buf := r.bufferPool.Get().(*bytes.Buffer)
defer func() {
buf.Reset()
r.bufferPool.Put(buf)
}()

if err := r.compressor.compress(buf, req.Body); err != nil {
return nil, err
}
Expand Down