Skip to content

feat: provide otel community demo attribute for service.criticality#2950

Open
bachgarash wants to merge 3 commits intoopen-telemetry:mainfrom
bachgarash:feat/prototype-service-criticality
Open

feat: provide otel community demo attribute for service.criticality#2950
bachgarash wants to merge 3 commits intoopen-telemetry:mainfrom
bachgarash:feat/prototype-service-criticality

Conversation

@bachgarash
Copy link

@bachgarash bachgarash commented Feb 2, 2026

Changes

This PR includes newly introduced attribute - service.criticality to demo

Implements open-telemetry/semantic-conventions#3088

Merge Requirements

For new features contributions, please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the docs
  • Appropriate Helm chart updates in the helm-charts

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

@bachgarash bachgarash requested a review from a team as a code owner February 2, 2026 18:26
@bachgarash bachgarash force-pushed the feat/prototype-service-criticality branch from 32fa7ba to 56e4121 Compare February 2, 2026 18:26
@github-actions github-actions bot added the helm-update-required Requires an update to the Helm chart when released label Feb 2, 2026
Copy link
Contributor

@puckpuck puckpuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to apply similar changes to docker-compose-minimal.yaml

@julianocosta89
Copy link
Member

Will this be part of SemConv 1.40.0?

@bachgarash
Copy link
Author

Will this be part of SemConv 1.40.0?

Not entirely sure, I hope so

@bachgarash bachgarash force-pushed the feat/prototype-service-criticality branch 2 times, most recently from 06b3bc0 to b3e5e7f Compare February 4, 2026 09:03
@bachgarash bachgarash requested a review from puckpuck February 4, 2026 09:03
@bachgarash bachgarash force-pushed the feat/prototype-service-criticality branch from b3e5e7f to ac287de Compare February 6, 2026 23:33
@bachgarash bachgarash force-pushed the feat/prototype-service-criticality branch from ac287de to 9624b09 Compare February 9, 2026 19:56
@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Feb 26, 2026
@horovits
Copy link
Contributor

@julianocosta89 can you advise what it takes to have the new attribute implemented in the demo?

@horovits
Copy link
Contributor

Will this be part of SemConv 1.40.0?

per (https://github.com/open-telemetry/semantic-conventions/releases/tag/v1.40.0) under Enhancements:

service: Add service.criticality attribute to classify services based on operational importance (open-telemetry/semantic-conventions#2986)

@github-actions github-actions bot removed the Stale label Feb 27, 2026
Copy link
Member

@julianocosta89 julianocosta89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an entry on the CHANGELOG

@@ -15,4 +15,117 @@
# service:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please let's add this example in the docs: https://opentelemetry.io/docs/demo/

We can create a subfolder under the demo to showcase sample configurations like this one.

Comment on lines +771 to +772
- OTEL_RESOURCE_ATTRIBUTES=${OTEL_RESOURCE_ATTRIBUTES},service.criticality=low
- OTEL_SERVICE_NAME=llm
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- OTEL_RESOURCE_ATTRIBUTES=${OTEL_RESOURCE_ATTRIBUTES},service.criticality=low
- OTEL_SERVICE_NAME=llm

LLM intentionally doesn't have instrumentation.

@julianocosta89
Copy link
Member

Will this be part of SemConv 1.40.0?

per (https://github.com/open-telemetry/semantic-conventions/releases/tag/v1.40.0) under Enhancements:

service: Add service.criticality attribute to classify services based on operational importance (open-telemetry/semantic-conventions#2986)

hey @horovits thx for pointing out.
I did see that last week, I just didn't have time to go through the PR.

Thx for the patience @bachgarash!
I've left 2 comments, and after them being addressed, we should be good to go!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

helm-update-required Requires an update to the Helm chart when released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants