feat: provide otel community demo attribute for service.criticality#2950
feat: provide otel community demo attribute for service.criticality#2950bachgarash wants to merge 3 commits intoopen-telemetry:mainfrom
Conversation
32fa7ba to
56e4121
Compare
puckpuck
left a comment
There was a problem hiding this comment.
We also need to apply similar changes to docker-compose-minimal.yaml
|
Will this be part of SemConv |
Not entirely sure, I hope so |
06b3bc0 to
b3e5e7f
Compare
b3e5e7f to
ac287de
Compare
ac287de to
9624b09
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
@julianocosta89 can you advise what it takes to have the new attribute implemented in the demo? |
per (https://github.com/open-telemetry/semantic-conventions/releases/tag/v1.40.0) under Enhancements:
|
julianocosta89
left a comment
There was a problem hiding this comment.
Please add an entry on the CHANGELOG
| @@ -15,4 +15,117 @@ | |||
| # service: | |||
There was a problem hiding this comment.
Please let's add this example in the docs: https://opentelemetry.io/docs/demo/
We can create a subfolder under the demo to showcase sample configurations like this one.
| - OTEL_RESOURCE_ATTRIBUTES=${OTEL_RESOURCE_ATTRIBUTES},service.criticality=low | ||
| - OTEL_SERVICE_NAME=llm |
There was a problem hiding this comment.
| - OTEL_RESOURCE_ATTRIBUTES=${OTEL_RESOURCE_ATTRIBUTES},service.criticality=low | |
| - OTEL_SERVICE_NAME=llm |
LLM intentionally doesn't have instrumentation.
hey @horovits thx for pointing out. Thx for the patience @bachgarash! |
Changes
This PR includes newly introduced attribute -
service.criticalityto demoImplements open-telemetry/semantic-conventions#3088
Merge Requirements
For new features contributions, please make sure you have completed the following
essential items:
CHANGELOG.mdupdated to document new feature additionsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.