Skip to content

Add linter checking we use the latest semconv version - #8231

Merged
dmathieu merged 8 commits into
open-telemetry:mainfrom
dmathieu:lint-semconv
Jan 7, 2026
Merged

Add linter checking we use the latest semconv version#8231
dmathieu merged 8 commits into
open-telemetry:mainfrom
dmathieu:lint-semconv

Conversation

@dmathieu

@dmathieu dmathieu commented Nov 28, 2025

Copy link
Copy Markdown
Member

This is inspired by open-telemetry/opentelemetry-collector-contrib#44606

Mongo is the only package with an older semconv. See #8230 to move forward with the upgrade.

@dmathieu dmathieu added the Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG label Nov 28, 2025
@dmathieu
dmathieu marked this pull request as ready for review November 28, 2025 12:53
@dmathieu
dmathieu requested a review from a team as a code owner November 28, 2025 12:53
Comment thread .golangci.yml Outdated
Comment thread .golangci.yml
dmathieu and others added 2 commits November 29, 2025 10:29
Co-authored-by: James Thompson <thompson.tomo@outlook.com>
Co-authored-by: James Thompson <thompson.tomo@outlook.com>
@codecov

codecov Bot commented Nov 29, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.3%. Comparing base (fd7efe4) to head (0a5de93).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #8231   +/-   ##
=====================================
  Coverage   82.3%   82.3%           
=====================================
  Files        192     192           
  Lines      13777   13777           
=====================================
  Hits       11342   11342           
  Misses      2030    2030           
  Partials     405     405           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pellared pellared left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 👍

Side note: I think it would be nice to have the process of bumping semconv (starting from generating new semconv) to be documented in CONTRIBUTING.md.

@dmathieu

Copy link
Copy Markdown
Member Author

Side note: I think it would be nice to have the process of bumping semconv (starting from generating new semconv) to be documented in CONTRIBUTING.md.

Yes. This seems like it should happen in core though.

@dmathieu

Copy link
Copy Markdown
Member Author

@open-telemetry/go-approvers this would welcome a second approval.

@pellared

Copy link
Copy Markdown
Member

Side note: I think it would be nice to have the process of bumping semconv (starting from generating new semconv) to be documented in CONTRIBUTING.md.

Yes. This seems like it should happen in core though.

I created open-telemetry/opentelemetry-go#7697

@dmathieu

dmathieu commented Jan 7, 2026

Copy link
Copy Markdown
Member Author

@open-telemetry/go-approvers ping for second approval :)

@dmathieu
dmathieu merged commit 472b1c0 into open-telemetry:main Jan 7, 2026
28 checks passed
@MrAlias MrAlias added this to the v1.40.0 milestone Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants