-
Notifications
You must be signed in to change notification settings - Fork 760
GenAI Utils Structure #3672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GenAI Utils Structure #3672
Conversation
@pmcollins - Mind taking a look? |
LGTM. @aabmass could you review it? |
instrumentation-genai/opentelemetry-genai-utils/src/opentelemetry/genai/utils/package.py
Outdated
Show resolved
Hide resolved
opentelemetry-instrumentation/src/opentelemetry/instrumentation/bootstrap_gen.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a comment -- other than that LGTM.
util/opentelemetry-genai-utils/src/opentelemetry/genai/utils/package.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The http util that lives in this same directory is a little different
- named
opentelemetry-util-http
- python package is
opentelemetry.util.http
WDYT of copying that pattern here? Asking because we can't easily change the package name on PyPI once published
Can you also add this package to the Pyright config like we did in #3646? I noticed we didn't add the tox boilerplate either, but we missed it for the other boilerplate PRs too. Please make sure it gets added in the future PRs, since that makes the tests run |
I think that's fine, the name has been updated |
Tox Boilerplate has been added with a basic test for version check to make tox pass. |
@aabmass The failing checks refer to a module "asyncclick". These checks showed up after merging main back into this branch. Is this something I should investigate in this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ty! One nit and I'll merge
Seems like an issue in main sorry |
Thanks for your patience. I reserved the package name on PyPI as well |
Description
This PR creates the Structure for the GenAI Utils package. The GenAI Utils package will include boilerplate and helpers to standardize instrumentation for Generative AI. Once implementation is complete, this package will provide APIs and decorators to minimize the work needed to instrument genai libraries, while providing standardization for generating both types of otel, "spans and metrics" and "spans, metrics and events"
Here's a link to the design document for the upcoming implementation: https://docs.google.com/document/d/1w9TbtKjuRX_wymS8DRSwPA03_VhrGlyx65hHAdNik1E/edit?tab=t.qneb4vabc1wc#heading=h.kh4j6stirken
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
N/A - No tests in this structure PR
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.