-
Notifications
You must be signed in to change notification settings - Fork 65
fix: Force Geneva Uploader to use HTTP1.1 - 400% increase in throughput #441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #441 +/- ##
=====================================
Coverage 53.1% 53.2%
=====================================
Files 70 70
Lines 10643 10648 +5
=====================================
+ Hits 5660 5665 +5
Misses 4983 4983 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
utpilla
reviewed
Sep 5, 2025
opentelemetry-exporter-geneva/geneva-uploader/src/ingestion_service/uploader.rs
Outdated
Show resolved
Hide resolved
utpilla
reviewed
Sep 5, 2025
opentelemetry-exporter-geneva/geneva-uploader/src/ingestion_service/uploader.rs
Outdated
Show resolved
Hide resolved
utpilla
reviewed
Sep 5, 2025
opentelemetry-exporter-geneva/geneva-uploader/src/ingestion_service/uploader.rs
Outdated
Show resolved
Hide resolved
…rvice/uploader.rs Co-authored-by: Utkarsh Umesan Pillai <[email protected]>
…rvice/uploader.rs Co-authored-by: Utkarsh Umesan Pillai <[email protected]>
utpilla
approved these changes
Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The server doesn't scale well with HTTP2 connection. So forcing client to use HTTP1.1
For each request containing 500 events, and sending 500 such request concurrently
(using HTTP1.1):
Throughput : ~390K
And using HTTP2:
Throughput: ~78K
Note - The HTTP2 scaling issue would be handled separately.
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes