feat: generate protos for profiles collector #3077
Merged
+386
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3077 +/- ##
=======================================
- Coverage 80.1% 80.1% -0.1%
=======================================
Files 126 126
Lines 21949 21949
=======================================
- Hits 17603 17599 -4
- Misses 4346 4350 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
korniltsev
commented
Jul 18, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for generating Rust protobuf bindings for the OpenTelemetry profiles collector service, enabling Rust applications to send profiling data to OpenTelemetry collectors.
- Adds profiles collector service proto file to the build configuration
- Generates new tonic client and server implementations for the ProfilesService
- Updates module structure to properly expose the profiles collector API
- Corrects module naming inconsistency for profiles v1development
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| opentelemetry-proto/tests/grpc_build.rs | Adds profiles_service.proto to the list of files for tonic generation |
| opentelemetry-proto/src/proto/tonic/opentelemetry.proto.collector.profiles.v1development.rs | Generated tonic client/server code for ProfilesService with export functionality |
| opentelemetry-proto/src/proto.rs | Adds profiles collector module and fixes profiles module naming consistency |
| opentelemetry-proto/CHANGELOG.md | Documents the addition of profiles collector proto generation |
lalitb
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This change allows setting up a profiles collector client. This will allow to send profiles to collectors from Rust.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes