-
Notifications
You must be signed in to change notification settings - Fork 273
Add in error type to rpc spans #2812 #2852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add in error type to rpc spans #2812 #2852
Conversation
Waiting on #2738 to progress this PR |
For JSON-RPC, Microsoft defines an Taking such a type name from the error object and using it as |
So for jsonrpc spans |
Co-authored-by: Trask Stalnaker <[email protected]>
053b989
to
cceb085
Compare
Head branch was pushed to by a user without write access
Fixes #2812
Changes
The rpc spans now contains the error.type attribute for capturing that detail.
Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.
Merge requirement checklist
[chore]