-
Notifications
You must be signed in to change notification settings - Fork 272
Remove network.type
from RPC spans and metrics
#2857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
6
commits into
main
Choose a base branch
from
copilot/fix-c2f9ac29-d78d-4786-98a9-6d2482d055cc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+43
−138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: trask <[email protected]>
network.type
from RPC spans / metricsnetwork.type
from RPC spans and metrics
Copilot finished work on behalf of
trask
October 2, 2025 17:48
trask
reviewed
Oct 2, 2025
Co-authored-by: trask <[email protected]>
Copilot finished work on behalf of
trask
October 2, 2025 18:03
trask
reviewed
Oct 3, 2025
trask
approved these changes
Oct 3, 2025
thompson-tomo
approved these changes
Oct 4, 2025
@trask this will need a rebase now that grpc doc has been merged |
lmolkova
approved these changes
Oct 15, 2025
…9-d78d-4786-98a9-6d2482d055cc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
network.type
from RPC attribute groups inmodel/rpc/common.yaml
rpc
attribute group (line 49)rpc.server
attribute group (line 88)rpc_service.server
attribute group (line 102)Summary
Successfully removed
network.type
attribute from all RPC spans and metrics following the same pattern used in PR #410 for HTTP. The attribute is still available in the registry for opt-in usage but is no longer included in RPC semantic conventions as a recommended attribute.Changes made:
network.type
frommodel/rpc/common.yaml
docs/rpc/rpc-spans.md
,docs/rpc/connect-rpc.md
,docs/rpc/json-rpc.md
.chloggen/2851.yaml
All validation checks pass:
✅ table-check
✅ schema-check
✅ misspell
✅ markdownlint
✅ chlog-validate
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.