Skip to content

Conversation

thompson-tomo
Copy link
Contributor

@thompson-tomo thompson-tomo commented Oct 12, 2025

Fixes #929

Changes

This removes the type field from resource documents as type is a concept for entities for which we have a dedicated registry documenting them.

Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.

Merge requirement checklist

  • CONTRIBUTING.md guidelines followed.
  • Change log entry added, according to the guidelines in When to add a changelog entry.
    • If your PR does not need a change log, start the PR title with [chore]
  • Links to the prototypes or existing instrumentations (when adding or changing conventions)

@thompson-tomo thompson-tomo requested review from a team as code owners October 12, 2025 03:33
@thompson-tomo thompson-tomo changed the title Remove type info from resources #929 [chore] Remove type info from resources #929 Oct 12, 2025
@thompson-tomo thompson-tomo changed the title [chore] Remove type info from resources #929 [chore] Remove type info from resource pages #929 Oct 13, 2025
Copy link
Member

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type was documented in https://github.com/open-telemetry/semantic-conventions/blob/main/docs/how-to-write-conventions/resource-and-entities.md after the original issue was created. It's an important property of the entity (analogous to metric or event name).

Closing this PR since the original issue is no longer relevant

@github-project-automation github-project-automation bot moved this from Untriaged to Blocked in Semantic Conventions Triage Oct 15, 2025
@lmolkova lmolkova closed this Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Clarify "type" in Resource semantic conventions

2 participants