Sort actions on "/monsters/[id]" page
#687
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eepMoody
approved these changes
Apr 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue on the front-end where creature actions were displayed alphabetically instead of by their order they appear in their original source statblocks. This fixes numerous issues on the
/monsters/[id]page where the order of the action lists really didn't make any sense and made finding them more difficult to parse (ie. multiattack infromation appearing after the attacks it references.This change was made possible open5e/open5e-api#668 on the API.
Related Issue
Closes #683
How was this tested
First, the code was visually AB tested against the
stagingbranch to make sure the creature items were being ordered in the first place. Then several monsters in the WOTC and A5E SRDs were compared to their source blocks to make sure that the order of the actions was correct.Finally, tests and build processes were run to make sure there were no unintentially app-breaking side-effects