[AI-204] Add centralized structured logging for MCP tool execution#299
Open
Kartikey-Malkani wants to merge 1 commit intoopenMF:mainfrom
Open
[AI-204] Add centralized structured logging for MCP tool execution#299Kartikey-Malkani wants to merge 1 commit intoopenMF:mainfrom
Kartikey-Malkani wants to merge 1 commit intoopenMF:mainfrom
Conversation
Contributor
|
Good work @Kartikey-Malkani , lgtm for me - Let me know your thoughts @IOhacker |
IOhacker
requested changes
Mar 30, 2026
Contributor
IOhacker
left a comment
IOhacker
left a comment
There was a problem hiding this comment.
Add this jira ticket in the PR title https://mifosforge.jira.com/browse/AI-204
Kartikey-Malkani
changed the title
Author
|
Thanks for the feedback! I’ve incorporated the Jira ticket in both the PR title and description, and made the requested updates. Also ensured consistency across validation, logging, and documentation changes. Please let me know if any further refinements are needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: https://mifosforge.jira.com/browse/AI-204
Summary - Add centralized MCP tool execution logging wrapper in mcp_server.py - Log tool name, parameters, execution duration, and response status - Ensure safe serialization and no crashes from complex object types - Added example comments showing log output format ## Validation behavior - Logs all tool invocations (success and failure) - Captures execution timing for performance analysis - Provides audit trail for security and debugging ## Verification - Tests pass: 10 passed Closes AI-204