Minor fixes, mostly obstructive warnings #1806
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does not make a big difference; other headers still include it and use variant for small helper types internally.
franzpoeschel
force-pushed
the
fix-some-warnings
branch
from
e6b7dc1 to
b1183b0
Compare
ax3l
approved these changes
Dec 2, 2025
Member
ax3l
left a comment
ax3l
left a comment
There was a problem hiding this comment.
Thank you!
Wow, GCC14 has a lot of regressions o.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
READ_LINEARand directly closing it again will print a warning because the deconstructor will try flushing, but no IO access has been made yet