Improve handling of large diffs in WebUI#19320
Open
Sahitya0805 wants to merge 1 commit intoopenSUSE:masterfrom
Open
Improve handling of large diffs in WebUI#19320Sahitya0805 wants to merge 1 commit intoopenSUSE:masterfrom
Sahitya0805 wants to merge 1 commit intoopenSUSE:masterfrom
Conversation
Sahitya0805
force-pushed
the
fix/issue-17856-large-diff-handling
branch
5 times, most recently
from
c1dc953 to
fcdf2e3
Compare
Sahitya0805
force-pushed
the
fix/issue-17856-large-diff-handling
branch
2 times, most recently
from
6410e3c to
543112c
Compare
github-actions
bot
added
Backend
Sahitya0805
force-pushed
the
fix/issue-17856-large-diff-handling
branch
2 times, most recently
from
f54f0a4 to
04e1c1f
Compare
Sahitya0805
changed the title
Sahitya0805
changed the title
Sahitya0805
force-pushed
the
fix/issue-17856-large-diff-handling
branch
4 times, most recently
from
f25002b to
728d370
Compare
- Add full_diff param support to set tarlimit to 0 in RequestController - Add truncated? to SourcediffComponent to detect truncated diffs - Replace manual alert with standard truncated_diff_hint in SourcediffComponent - Add coverage specs for truncated? and full_diff param
Sahitya0805
force-pushed
the
fix/issue-17856-large-diff-handling
branch
from
728d370 to
c5d0168
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve handling of large diffs in WebUI
This PR addresses the issue where large diffs are truncated by providing a "full diff" expansion option.
Key Improvements
RequestControllernow supports afull_diffparameter to load complete diffs.truncated_diff_hintin the redesigned WebUI.truncated?method toSourcediffComponentto correctly detect and signal truncated diffs in the view.Verification Plan
Automated Tests
bundle exec rspec spec/controllers/webui/request_controller_spec.rbManual Verification
Closes #17856