Fix crash when creating an existing patchinfo package#19374
Open
Sahitya0805 wants to merge 1 commit intoopenSUSE:masterfrom
Open
Fix crash when creating an existing patchinfo package#19374Sahitya0805 wants to merge 1 commit intoopenSUSE:masterfrom
Sahitya0805 wants to merge 1 commit intoopenSUSE:masterfrom
Conversation
2949ffe to
29f898e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey Friends,
this PR resolves a crash in the Patchinfo creation flow when a package with the name "patchinfo" already exists in the project. Instead of throwing an
ActiveRecord::RecordInvalidexception, the controller now catches it and shows a user-friendly error message.Fixes #18711
To verify this change:
patchinfomanually if it doesn't exist.patchinfo".Automated tests:
Run the regression test to ensure the fix works as expected:
bundle exec rspec spec/controllers/webui/patchinfo_controller_spec.rb:114Detailed Changes:
PatchinfoController#createto rescueActiveRecord::RecordInvalid.patchinfo_controller_spec.rbto cover the validation failure scenario.