[codex] Publish Tart to openai/homebrew-tools#1277
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 50903edd5d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| env: | ||
| GORELEASER_KEY: ${{ secrets.GORELEASER_KEY }} | ||
| GITHUB_TOKEN: ${{ steps.app-token.outputs.token }} | ||
| HOMEBREW_TAP_GITHUB_TOKEN: ${{ steps.tap-token.outputs.token }} |
There was a problem hiding this comment.
Pass AC_PASSWORD to the signing step
In tag releases, .ci/sign-release.sh invokes gon gon.hcl, and gon.hcl reads the notarization password from @env:AC_PASSWORD; however this secret is only scoped to the earlier “Import signing certificate” step, not to this GoReleaser step. On any non-snapshot release gon runs without that env var and fails to notarize/sign even when the publish environment has the secret. Please add AC_PASSWORD: ${{ secrets.AC_PASSWORD }} here, or change gon.hcl to use the stored notary profile.
Useful? React with 👍 / 👎.
| @@ -1,7 +1,11 @@ | |||
| #!/bin/sh | |||
|
|
|||
| set -e | |||
There was a problem hiding this comment.
What the rationale behind this change (whole file)?
| - cp Resources/embedded.provisionprofile dist/tart_darwin_all/tart.app/Contents/ | ||
| - cp Resources/Info.plist dist/tart_darwin_all/tart.app/Contents/ | ||
| - cp "Resources/actool/UPW Tart.icns" "Resources/actool/Assets.car" dist/tart_darwin_all/tart.app/Contents/Resources/ | ||
| - gon gon.hcl |
There was a problem hiding this comment.
What's the rationale behind dropping gon?
Summary
openai/tartandopenai/homebrew-toolsFormula/tart.rbthrough atart-{{ .Version }}pull request inopenai/homebrew-toolsopenai/tools/softnetbrew install openai/tools/tartmacos-26publishenvironmentRelease blocker — do not cut a release yet
The
publishenvironment currently hasGORELEASER_KEY,RELEASE_APP_ID, andRELEASE_APP_PRIVATE_KEY, but it is still missing:AC_PASSWORDMACOS_CERTIFICATEThose values currently exist only as encrypted Cirrus CI variables and cannot be copied from their ciphertext. Add both secrets to the
publishenvironment before creating the next Tart release tag.The corresponding
openai/homebrew-toolsvalidation/auto-merge support for Tart must also land before the first release using this workflow.Install
Behavior change
The old Cirrus release task's Sentry debug-file uploads and Sentry release creation are intentionally not migrated. Restoring them would require separately provisioning and scoping
SENTRY_AUTH_TOKEN.Validation
actionlint1.7.12goreleaser check --softwith GoReleaser Pro 2.16.0goreleaser release --skip=publish --snapshot --cleancodesign --verify --deep --strictdist/homebrew/Formula/tart.rband checked withruby -cgit diff --check