support ranger (and therefore random forests) - #39
Merged
Merged
Conversation
Collaborator
|
This all seems to work well now - thanks Jack! Feel free to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
"ranger"as anengineoption forbuild_dw_model()andtune_dw_model().parsniphelps this carry through to the rest of the package relatively simply, with only a few small tweaks required.These tweaks are mainly related to formatting importance as a number instead of a percentage (ranger gives you permutation importance, as opposed to %gain from boosted trees). The rest is documentation.
This PR is a bit of a proof of concept to show how easy it is to add new engines to
deweathernow it runs onparsnip. We don't necessarily have to supportranger(or any random forests).