ci: enforce contract compatibility on pull requests - #161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Runs the published contract fixtures through the real CLI decoders on every PR and restores all live branch-protection compatibility jobs on pull requests.
Why?
The L2 job only validated fixtures against schemas from the same repository and skipped pull requests. That allowed
normalizeRemoteConfigand other tolerant decoders to hide server drift while CI stayed green. GitHub branch protection already requirescontract schema (L2),curl|bash smoke, andold-cli compat, so skipping those jobs also left required checks with no result.Testing
go vet ./...passesOPENBOOT_CONTRACT_DIR=/private/tmp/openboot-contract-fixture go test -v -tags=contract ./test/contractmake test-unitpassesCross-repo checklist
openboot.dev; this changes CLI CI only.openboot-contractfixtures.Notes for reviewer
The new remote-config test decodes the canonical wire shape separately, then compares it with
UnmarshalRemoteConfigFlexiblefield-for-field. A canonical fixture that causes the CLI to repair, move, or drop fields now fails instead of being silently normalized.On
repository_dispatch, the contract checkout uses the dispatched commit SHA. Other events test the current contractmainbranch.