feat(macos): capture "Click wallpaper to show desktop" preference#66
Merged
Conversation
Add a "Desktop & Stage Manager" category covering com.apple.WindowManager "EnableStandardClickToShowDesktop". Previously this key was outside the DefaultPreferences catalog, so `openboot snapshot` silently dropped it and `openboot install` couldn't write it, leaving the wallpaper-click behaviour unmanaged. Default is false (macOS Sonoma+ behaviour — wallpaper click only hides windows while Stage Manager is active). Set to true for the pre-Sonoma "always reveal desktop" behaviour.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a "Desktop & Stage Manager" category covering
com.apple.WindowManagerEnableStandardClickToShowDesktop. Previously this key was outside theDefaultPreferencescatalog, soopenboot snapshotsilently dropped it (capture skips any pref not in the catalog) andopenboot installcouldn't write it.User reported the gap with a screenshot of the snapshot UI showing the category at 1/1 with the stored value, indicating the web side knows about the key but the CLI snapshot was never capturing it.
Default is
falseto match macOS Sonoma+'s built-in default (wallpaper click only hides windows while Stage Manager is active). Set totruefor the pre-Sonoma "always reveal desktop" behaviour.Follows the same pattern as #58 (hot corners) and the menu bar / Control Center icons PR — single-file change to
internal/macos/categories.go, picked up automatically byDefaultPreferences→ snapshot capture +Configure→ restore.Test plan
go vet ./internal/macos/... ./internal/snapshot/... ./internal/archtest/...go test ./internal/macos/... ./internal/archtest/...(L1 incl.TestDefaultPreferences_DerivedFromCategoriesandTestDefaultPreferences_NoDuplicateKeys)