Open
Conversation
Pull Request Functional Test Report for #3360 / a46af8fVirtual Devices
Hardware Devices
|
Pull Request Test Coverage Report for Build 22043100843Details
💛 - Coveralls |
hnnagashree
assigned
morrowc,
marcushines and
mihirpitale-googler and unassigned
morrowc and
marcushines
morrowc
reviewed
Sep 22, 2024
Contributor
morrowc
left a comment
morrowc
left a comment
There was a problem hiding this comment.
there are some Check() fialure things to address here
feature/security/gnsi/certz/tests/internal/setup_service/setup_service.go
Outdated
Show resolved
Hide resolved
feature/security/gnsi/certz/tests/internal/setup_service/setup_service.go
Outdated
Show resolved
Hide resolved
|
Pre-merge Action: @ram-mac , kindly execute this test within our environment before merging. We can proceed with the merge upon successful test completion |
dplore
requested changes
Nov 25, 2025
Member
dplore
left a comment
dplore
left a comment
There was a problem hiding this comment.
Please address the comments on this PR before it can be merged
Member
|
@priyacj please address the open comments |
Member
|
@priyacj please address the open comments so we can proceed with merging this PR. Thanks! |
…rtificate_rotation_test.go probably we should have failed here instead of continued along. Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
this is a good change/comment. Co-authored-by: Darren Loher <dloher@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
certz3.1 gNSI Server Certificate Rotation