feat(data engine): Add the VolumeAttributesClass feature#444
feat(data engine): Add the VolumeAttributesClass feature#444tiagolobocastro merged 1 commit intoopenebs:developfrom
Conversation
|
I checked these options manually on cluster 1.34.3 without integration testing: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #444 +/- ##
========================================
Coverage 98.46% 98.46%
========================================
Files 2 2
Lines 979 979
========================================
Hits 964 964
Misses 8 8
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tiagolobocastro
left a comment
There was a problem hiding this comment.
Thanks @rybas-dv for your great work and your patience in the discussions
Thank you for what you do, it's very important. I was glad to make my small contribution. |
|
@rybas-dv , Can you please squash commits. |
Signed-off-by: rybas.dmitriy <dirybas@rambler.ru>
Awesome thank you, I'll go ahead and merge my pr then. There was prior changes missing as well (for the |
Why is this PR required? What issue does it fix?:
The OEP discussed the process of implementing the VAC, in this PR a possible implementation.
What this PR does?:
This PR adds the ability to support VAC to the controller for k8s clusters with and without VAC support.
Does this PR require any upgrade changes?:
Kubernetes CSI Sidecar Containers version need to be updated.
If the changes in this PR are manually verified, list down the scenarios covered::
Any additional information for your reviewer? :
Please help me understand how to implement integration tests to verify that VAC applied on cgroup /sys/fs/cgroup/ correctly.
Checklist:
<type>(<scope>): <subject>