feat: add global helm global values#831
Open
krishnaGajabi wants to merge 5 commits intoopenebs:developfrom
Open
feat: add global helm global values#831krishnaGajabi wants to merge 5 commits intoopenebs:developfrom
krishnaGajabi wants to merge 5 commits intoopenebs:developfrom
Conversation
Signed-off-by: krishnaGajabi <gajbikrishna23@gmail.com>
Signed-off-by: krishnaGajabi <gajbikrishna23@gmail.com>
Signed-off-by: krishnaGajabi <gajbikrishna23@gmail.com>
Signed-off-by: krishnaGajabi <gajbikrishna23@gmail.com>
Signed-off-by: krishnaGajabi <gajbikrishna23@gmail.com>
Contributor
Author
|
CI tests(images.sh script) are falling because we have set global.imageRegistry to an empty string. earlier the value used to be from localpv helm chart where it was explicitly set to docker.io. need the changes to be done in localpv before this changes are merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this PR required? What issue does it fix?
Currently, the Helm charts do not provide global variables for configuring common parameters such as the image registry, image pull secrets, image pull policy, and analytics settings.
When deploying the OpenEBS Helm charts, users often need to override these values across multiple subcharts and components. This makes it difficult to locate and configure all the required fields consistently. Providing global variables simplifies configuration and improves the user experience.
What does this PR do?
This PR introduces the following global configuration variables:
These variables allow users to configure common settings in a single place, which will then be applied across the chart components.
Does this PR require any upgrade changes?
No.
This change is backward compatible and does not require any upgrade steps.
Verification
The changes were verified using the following scenarios:
Rendered the templates using helm template to confirm correct value substitution.
Deployed the chart on a Kubernetes cluster with 3 worker nodes (kubeadm-based setup).
Verified that the global values are rendered and applied correctly across the components.