feat(plugin): add node delete command and opts#835
Open
Conversation
niladrih
force-pushed
the
node-delete-plugin
branch
from
d1a3c31 to
9d665cc
Compare
tiagolobocastro
approved these changes
Apr 16, 2026
There was a problem hiding this comment.
Pull request overview
Adds a delete node command to the Kubernetes plugin with optional DiskPool CR cleanup, and renames the pool cleanup flag from --cleanup-cr to --cleanup-dsp.
Changes:
- Introduces
delete nodesupport (purge) with optional concurrent DiskPool CR cleanup (--cleanup-dsp). - Refactors DiskPool cleanup CLI options into a shared
CleanupDspArgsused by both pool and node delete flows. - Adds Kubernetes-side listing of DiskPool CRs by node and a high-level
cleanup_dsphelper to apply timeout + not-found semantics.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| k8s/plugin/src/resources/mod.rs | Adds node delete CLI wiring and integrates --cleanup-dsp behavior for pool/node deletes. |
| k8s/plugin/src/resources/diskpool_cleanup.rs | Adds DiskPool CR listing-by-node and a higher-level cleanup wrapper used by delete commands. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
niladrih
force-pushed
the
node-delete-plugin
branch
2 times, most recently
from
5740060 to
81e59c8
Compare
Abhinandan-Purkait
approved these changes
Apr 16, 2026
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Changes: - Adds node delete command and opts - Change --cleanup-cr to --cleanup-dsp Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
niladrih
force-pushed
the
node-delete-plugin
branch
from
81e59c8 to
154949d
Compare
Member
Author
|
bors merge |
Contributor
|
🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
bors-openebs-mayastor bot
pushed a commit
that referenced
this pull request
Apr 16, 2026
835: feat(plugin): add node delete command and opts r=niladrih a=niladrih Changes: - Adds node delete command and opts - Change --cleanup-cr to --cleanup-dsp Co-authored-by: Niladri Halder <niladri.halder26@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes: